-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added disableSparseSamples #2815
base: dev
Are you sure you want to change the base?
Conversation
Clang format Updated copyright, added __main__ Added testDisableSparseSamples.py updating to match Autodesk style Updated to work w/ maya test suite Disabled sparse check on joint
@seando-adsk apologies, I just updated our CLA and sent it over with the name changes on there. |
@dgovil Thanks I got it. We'll proceed with an internal discussion about these changes. |
Hi @tryptik and @dgovil, I am wondering if we have a test scene that we can look at that shows the issue with the duplicate values when using the |
Hi, @santosd, I agree that the issue may be in the |
Hi @tryptik sorry for the delay on this one. I ran what is in the script locally on my machine (the building of the scene and the export) and I was not able to reproduce the issue that you show in your screen capture.
Then I ran this for export:
I then tried importing the resulting file to check the animation curves, but I am not seeing the issue you see. Let me know if I am missing something. Thank you. |
Hi, @santosd, sorry it took me a bit to get to this. If you re-import that Usd into Maya, you should see: I used |
Thank you @tryptik I am seeing the issue. I will work with @seando-adsk to look further into the issue and see if we can fix this on the sparser end. |
The
UsdUtilsSparseValueWriter
seems to write duplicate values for some curves. This P/R adds adisableSparseSamples
flag to themayaUSDExport
command. When true, the sparse sample writer is disabled for the export.This issue has been observed in the animation data in
UsdSkelAnimation
prims - similar values on anXForm
do not seem to yield the same result. The disabling of the sparse sampling was applied across the board as a precaution. The modified test case shows where the issue is found in the scale animation. The result of the sparse sample export can be seen in the figure below:I am covered under the Apple CLA as John Hood.